fix(protocol): fix BridgedERC20V2.sol initializer logic #17823
Merged
+48
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
requested review from
Brechtpd,
adaki2004,
davidtaikocha and
cyberhorsey
dantaik
changed the title
fix(protocol): fix BridgedERC20V2.sol initializer logic
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adaki2004
reviewed
Jul 21, 2024
adaki2004
approved these changes
Jul 22, 2024
Brechtpd
approved these changes
Jul 22, 2024
davidtaikocha
approved these changes
Jul 24, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BridgedERC20V2 could not be used to upgrade BridgedERC20 without the new
init2()function. I also changedinit()to mark implementation as version2so contract upgraded fromBridgedERC20will have the same version number as newly deployedBridgedERC20V2.